Use better defaults for physically based camera parameters #4617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to make sure that shutter speed and aperture won't have too big of an impact on depth of field and motion blur, given the eventual future where we might want to have those effect depend on the camera parameters.
slimbuck
approved these changes
Sep 5, 2022
mvaligursky
approved these changes
Sep 5, 2022
There was a problem hiding this comment.
looks like really sensible defaults.
iso 1000 is no problem on modern cameras .. you mostly care about aperture and shutter to control DOF and blur .. and f16 and 1/1000 sounds like a good option that matches our visuals currently (everything is sharp, and no motion blur)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to make sure that shutter speed and aperture won't have too big of an impact on depth of field and motion blur, given the eventual future where we might want to have those effect depend on the camera parameters.